bitcoin-qt --help shows error
bitcoin-qt: chainparamsbase.cpp:56: const CBaseChainParams& BaseParams(): Assertion 'pCurrentBaseParams' failed. Aborted
after the help is printed. The reason is we return before SelectParamsFromCommandLine(), not sure if there is a cleaner fix to this problem though.
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4532_d784608dc40b37c85130f038cd657c66a890670d/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
We should look for a better fix, this is really ugly. Why is this needed here an not in bitcoind/bitcoin-cli etc?
Looks like underlying issue is here: It tries to do a LogPrint before initialization of the logging system / datadir.
[#10](/bitcoin-bitcoin/10/) 0x00005555555c5a89 in LogPrint (category=0x0, format=0x555555887b23 "Stopping thread\n") at ./util.h:141
[#11](/bitcoin-bitcoin/11/) BitcoinApplication::~BitcoinApplication (this=0x7fffffffdc30, __in_chrg=<optimized out>) at qt/bitcoin.cpp:293
[#12](/bitcoin-bitcoin/12/) 0x00005555555b7d25 in main (argc=2, argv=<optimized out>) at qt/bitcoin.cpp:613
Going to solve this by making LogPrintStr check that the chain parameters have been configured.