The cleaned user agent does not conform to BIP0014 #4537

issue davecgh opened this issue on July 15, 2014

davecgh commented at 4:46 PM on July 15, 2014: contributor

The cleaned user agent that is set here makes use of the SanitizeString function which strips characters that are valid per BIP0014.

As stated in BIP0014, the reserved characters for BIP0014 are /, :, (, ), and ;. However the SanitizeString functions strips the ( and ) characters.
laanwj added the label RPC on Jul 28, 2014
laanwj referenced this in commit 8ab7a05476 on Sep 25, 2014
laanwj referenced this in commit d14d7deff0 on Sep 25, 2014
sipa closed this on Sep 26, 2014
wtogami referenced this in commit d24d61efeb on Oct 2, 2014
wtogami referenced this in commit a47ba8f6b4 on Nov 14, 2014
wtogami referenced this in commit 5f629d50ed on Dec 23, 2014
reddink referenced this in commit 030e8536ae on May 27, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Labels