Reject behavior does not coincide with BIP0061 #4538

issue davecgh opened this issue on July 15, 2014

davecgh commented at 4:51 PM on July 15, 2014: contributor

This code in the AcceptToMemoryPool function for rejecting transactions with missing and/or fully spent transactions sends a reject code of 0x12 which, according to BIP0061 is Duplicate version message received.

I suspect it is probably easier to fix the BIP at this point, but I did want to point out the implementation does not match the BIP.
jrick commented at 11:57 PM on July 15, 2014: none

There are some other reject reasons that are shared between different data types (for example, 0x10 Invalid being shared by both tx and block), so I suspect that 0x12 is just missing from the table of tx reject reasons in the BIP.
laanwj added the label P2P on Sep 25, 2014
laanwj commented at 4:19 PM on February 9, 2016: member

The BIP was fixed by @NicolasDorier in https://github.com/bitcoin/bips/pull/148
laanwj closed this on Feb 9, 2016
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels