Categorize rpc help overview #4539

pull cozz wants to merge 1 commits into bitcoin:master from cozz:cozz11 changing 2 files +106 −84

cozz commented at 8:29 PM on July 15, 2014: contributor

in src/rpcserver.cpp:None in ffbfc1e953 outdated

 293 | +    { "mining",             "getnetworkhashps",       &getnetworkhashps,       true,      false,      false },
 294 | +    { "mining",             "prioritisetransaction",  &prioritisetransaction,  true,      false,      false },
 295 | +    { "mining",             "submitblock",            &submitblock,            true,      true,       false },
 296 | +
 297 | +    /* Coin generation */
 298 | +    { "generating",         "getgenerate",            &getgenerate,            true,      false,      false },

laanwj commented at 8:23 AM on July 17, 2014:

These must be inside the #ifdef ENABLE_WALLET

cozz commented at 1:31 AM on July 18, 2014:

Yeah I got that wrong again, thanks, now fixed.

laanwj commented at 12:51 PM on July 28, 2014: member

You have a spelling error in your commit message :p
Personally I'd prefer markdown/mediawiki-like syntax

== Blockchain ==
getbestblockhash
getblock "hash" ( verbose )
getblockchaininfo
getblockcount
getblockhash index
getdifficulty
getrawmempool ( verbose )
gettxout "txid" n ( includemempool )
gettxoutsetinfo
verifychain ( checklevel numblocks )

== Control ==
....

In the current state I have difficulty visually separating the category names from the command names.

Categorize rpc help overview df3d321ce8
cozz renamed this:
~~Categorisze rpc help overview~~
Categorize rpc help overview
on Jul 28, 2014
cozz commented at 2:05 PM on July 28, 2014: contributor

Updated as requested. Good idea, looks better now.
BitcoinPullTester commented at 2:15 PM on July 28, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4539_df3d321ce800272e315347a08af4548f2d95816d/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj added the label Docs and Output on Jul 31, 2014
laanwj added the label RPC on Jul 31, 2014
jgarzik commented at 2:58 PM on August 4, 2014: contributor

ut ACK. Manually scanned the patched cmd table to make sure no booleans were surreptitiously harmed in the conversion.
laanwj referenced this in commit 6b5b7cbfb4 on Aug 11, 2014
laanwj commented at 2:23 PM on August 11, 2014: member

Merged via 6b5b7cb
laanwj closed this on Aug 11, 2014
dexX7 referenced this in commit be9cb7aafe on Oct 13, 2014
reddink referenced this in commit 8035ebf8e4 on May 27, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Labels