[Qt] Fix thin space in URI #4563

pull cozz wants to merge 1 commits into bitcoin:master from cozz:cozz17 changing 3 files +9 −2

cozz commented at 2:36 AM on July 20, 2014: contributor
- fix bug: no thin spaces in BitcoinURI
- remove spaces when copying amount to clipboard through context-menu (to be consistent with transactions context-menu)
- unrelated, but I noticed amount is not right-aligned in receive tab
[Qt] Fix thin space in URI 027dcdc792
BitcoinPullTester commented at 3:12 AM on July 20, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4563_027dcdc792e006ea90afe90b7373ba5a111bd9bc/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

in src/qt/guiutil.cpp:None in 027dcdc792

 186 | @@ -187,7 +187,7 @@ QString formatBitcoinURI(const SendCoinsRecipient &info)
 187 |  
 188 |      if (info.amount)
 189 |      {
 190 | -        ret += QString("?amount=%1").arg(BitcoinUnits::format(BitcoinUnits::BTC, info.amount));
 191 | +        ret += QString("?amount=%1").arg(BitcoinUnits::format(BitcoinUnits::BTC, info.amount, false, BitcoinUnits::separatorNever));

laanwj commented at 5:27 AM on July 20, 2014:

Ouch, good catch.

laanwj merged this on Jul 20, 2014
laanwj closed this on Jul 20, 2014
laanwj referenced this in commit fb21bf6951 on Jul 20, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors

cozz

BitcoinPullTester

laanwj