remove an unneded .c_str() in OpenNetworkConnection() #4567

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:net_cleanup_rem_strconv changing 1 files +1 −1
  1. Diapolo commented at 1:00 PM on July 21, 2014: none

    No description provided.

  2. remove an unneded .c_str() in OpenNetworkConnection() f469f79ff8
  3. BitcoinPullTester commented at 1:17 PM on July 21, 2014: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4567_f469f79ff8f33c8d487d48cd6af83e1c73cf0a94/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

  4. laanwj commented at 6:13 AM on July 23, 2014: member

    Good catch.

    BTW: we should add CNode* FindNode(std::string addrName) to net.h. It has the other two overloads but not this one, so I spent some time trying to find how passing a std::string would even compile :)

  5. laanwj merged this on Jul 25, 2014
  6. laanwj closed this on Jul 25, 2014

  7. laanwj referenced this in commit 32235a3bb9 on Jul 25, 2014
  8. Diapolo deleted the branch on Jul 25, 2014
  9. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 18:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me