Add CBloomFilter::clear() method #4568

pull dgenr8 wants to merge 1 commits into bitcoin:master from dgenr8:bloom_clear changing 3 files +13 −0

dgenr8 commented at 6:53 PM on July 21, 2014: contributor

Might come in handy.
CBloomFilter::clear() method 9c347313f7
BitcoinPullTester commented at 7:15 PM on July 21, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4568_9c347313f7f504d602a9d744f1ad7aee4e3d6f9a/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
dgenr8 commented at 7:18 PM on July 21, 2014: contributor

This change has been tested extensively. It has been deployed and exercised on mainnet since 2014-05-22.
laanwj commented at 6:53 AM on July 22, 2014: member

It sounds like a useful addition, however I don't like to add dead code. Are there any places in the current code where this could be used?
dgenr8 commented at 7:23 AM on July 22, 2014: contributor

@laanwj I just broke it out because you mentioned it. No problem if you want to close this or set it aside.
laanwj commented at 7:51 AM on July 22, 2014: member

Yes I still think it makes sense API-wise. And you add a test. So ACK.
jgarzik commented at 4:50 PM on July 29, 2014: contributor

ut ACK
laanwj merged this on Jul 31, 2014
laanwj closed this on Jul 31, 2014
laanwj referenced this in commit 2870014f3a on Jul 31, 2014
dgenr8 deleted the branch on Sep 19, 2018
DrahtBot locked this on Sep 8, 2021

Contributors