Bugfix: make CCoinsViewMemPool support pruned entries in underlying cache #4575

1. 
   sipa commented at 1:31 pm on July 23, 2014: member

   Since #4505 it can happen that pcoinsTip contains pruned but existing CCoins entries, representing deleted/reorged transactions.

   CCoinsViewMemPool::GetCoins does not deal correctly with this, as it first checks for an entry in the underlying cache (which can be pruned) and then for one in the mempool. Swap these, as the mempool is guaranteed never to conflict with the underlying cache, and the mempool cannot contain pruned transactions.

   Thanks to @mikehearn for reporting.

2. 
   mikehearn commented at 1:37 pm on July 23, 2014: contributor

   Looks good: I found this problem whilst extending the pull tester with getutxo tests, and this fixes the bug for me.
3. Bugfix: make CCoinsViewMemPool support pruned entries in underlying cache ad08d0b95b
4. 
   BitcoinPullTester commented at 2:29 pm on July 23, 2014: none

   Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4575_ad08d0b95bd8e35b74f5f36cfa3c48ae9583b28c/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
5. 
   laanwj commented at 4:03 pm on July 23, 2014: member

   Untested ACK
6. laanwj merged this on Jul 24, 2014
7. laanwj closed this on Jul 24, 2014

   ---

8. laanwj referenced this in commit 7eb3d6152f on Jul 24, 2014
9. MarcoFalke locked this on Sep 8, 2021

Contributors
sipa mikehearn BitcoinPullTester laanwj