Came up in #4567 Also make the argument a const std::string & instead of pass-by-value.
Add missing FindNode prototype to net.h #4584
pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2014_07_missing_findnode_prototype changing 2 files +2 −1-
laanwj commented at 2:31 PM on July 24, 2014: member
-
0430c30af1
Add missing FindNode prototype to net.h
Also make the argument a const std::string & instead of pass-by-value.
-
BitcoinPullTester commented at 3:57 PM on July 24, 2014: none
Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/p4584_0430c30af118637819f70eaf3d10a77d910639e3/ for binaries and test log.
This could happen for one of several reasons:
- It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts (please tweak those patches in qa/pull-tester)
- It adds/modifies tests which test network rules (thanks for doing that), which conflicts with a patch applied at test time
- It does not build on either Linux i386 or Win32 (via MinGW cross compile)
- The test suite fails on either Linux i386 or Win32
- The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)
If you believe this to be in error, please ping BlueMatt on freenode or TheBlueMatt here.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
Diapolo commented at 5:13 AM on July 25, 2014: none
I was about to update my pull, good I saw this :). @BitcoinPullTester error seems unrelated
Error: Error: Disk space is low!... - laanwj merged this on Jul 25, 2014
- laanwj closed this on Jul 25, 2014
- laanwj referenced this in commit 3955c3940e on Jul 25, 2014
- MarcoFalke locked this on Sep 8, 2021