[Qt] allow users to set -onion via GUI

Diapolo commented at 4:22 pm on July 25, 2014: none

also allow users to see, if the default proxy (-proxy) is used for IPv6 and Onion
based on #4871 (formerly #2575)

proxy

laanwj commented at 6:44 am on July 26, 2014: member

Looks good.

As discussed in #2575 I’d like to simplify this to:

A clearnet proxy for IPv4 and IPv6 and name-based lookups (except *.onion, and possibly other ‘darknet’s in the future)
A proxy for .onion. This defaults to the clearnet proxy *if the onion network is enabled at all.

laanwj added the label GUI on Jul 31, 2014

Diapolo renamed this:
~~[Qt] allow users to set -proxy6 and -tor via GUI~~
[Qt] allow users to set -tor via GUI
on Sep 23, 2014

Diapolo renamed this:
~~[Qt] allow users to set -tor via GUI~~
[Qt] allow users to set -onion via GUI
on Sep 23, 2014

Diapolo commented at 1:18 pm on September 23, 2014: none

@laanwj Removed the -proxy6 stuff and rebased on the recently updated core pull.

BitcoinPullTester commented at 1:46 pm on September 23, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4587_776d006492d75c94cbff1edf7fae760f0a95ebcf/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

jonasschnelli commented at 3:06 pm on January 9, 2015: contributor

Needs rebase or close due inactivity.

Diapolo commented at 3:14 pm on January 9, 2015: none

No, this needs review and help with #4871, which no one is interessted in :D.

jonasschnelli commented at 3:23 pm on January 9, 2015: contributor

Sorry. Your right. It’s on top of #4871

Diapolo commented at 1:48 pm on May 14, 2015: none

Rebased to latest #4871 and fixed a small bug that was causing -onion to be missing in the options dialog, when the GUI setting was overridden.

Diapolo commented at 5:52 am on June 15, 2015: none

Same here, this will be rebased after #6272 is merged.

Diapolo commented at 8:38 pm on June 19, 2015: none

Rebased and passing travis :).

Diapolo commented at 7:26 pm on June 23, 2015: none

@laanwj @jonasschnelli Mind taking a closer look now?

Diapolo commented at 7:17 pm on July 21, 2015: none

@jonasschnelli @laanwj This should be ready.

jonasschnelli commented at 7:30 pm on July 21, 2015: contributor

Gave it a short test.

Why can’t i unselect/select the IPv4/IPv6/Tor checkboxes (i didn’t start reading why in the PRs description because IMO this must be clear within the app). If it’s just as a visual prove what networks are supported by the proxy, it should not use read-only checkboxes.

The new height of the settings window does somehow look strange on the other tabs. Auto-Resizing like this (https://vid.me/F53C) would be a better approach (check: http://stackoverflow.com/questions/11441809/resize-window-using-qpropertyanimation).

IMO the autoresizing would be nice but should not hold this PR back.

jonasschnelli commented at 7:31 pm on July 21, 2015: contributor

Diapolo commented at 8:44 pm on July 21, 2015: none

@jonasschnelli I choose the read-only checkbox approach as that seemed easy to do. What elemet do you suggest? As you discovered the state is not changable via the boxes, they just give information.

The resize issue is a different one and as far as I understand the link you gave me, this is just for getting a nice and smooth animation, but I don’t even know how to resize a window so that the contents and size are matching and that it looks good ;). IMHO our client suffers from these issue nearly everywhere.

jgarzik commented at 6:03 pm on July 23, 2015: contributor

ut ACK

Is this ready for merging? Blockers appear to be resolved.

jonasschnelli commented at 6:06 pm on July 23, 2015: contributor

Readonly-Checkboxes as visual indicator for a available option (but while actually supporting no interaction) should be avoided. But i can address this in another upcoming PR after merging.

I would recommend to use the checkmark icon instead (https://github.com/bitcoin/bitcoin/blob/master/src/qt/res/icons/transaction2.png).

Diapolo commented at 6:07 am on July 24, 2015: none

@jonasschnelli I’d love to get this in or you could just add a commit to it. But I’d love to move forward.

jonasschnelli commented at 10:21 am on July 24, 2015: contributor

Doesn’t compile at the moment because of the recent “emit” changes (https://github.com/bitcoin/bitcoin/pull/6433).

[Qt] allow users to set -onion via GUI

- also allow users to see, if the default proxy (-proxy) is used for
  reaching peers via IPv6 or Tor

ed166dfa82

Diapolo commented at 10:29 am on July 24, 2015: none

@jonasschnelli fixed the emit problem.

jonasschnelli commented at 10:56 am on July 24, 2015: contributor

I think this looks better. Commit: https://github.com/jonasschnelli/bitcoin/commit/3ae243422abfbdaa8c5a56ebdf86d4fedeaa467c

laanwj commented at 11:41 am on August 7, 2015: member

@jonasschhnelli I like what you’re trying to do, but I’m not sure it’s better:

The checkbox icon is always black, also in themes that themselves have a black background
It doesn’t fit in with the rest of the UI (check styles are slightly different)

laanwj commented at 11:41 am on August 7, 2015: member

Going to merge this as-is for now. You can improve it later.

laanwj merged this on Aug 7, 2015

laanwj closed this on Aug 7, 2015

laanwj referenced this in commit 0c465f5e60 on Aug 7, 2015

jonasschnelli commented at 12:01 pm on August 7, 2015: contributor

ACK.

Diapolo deleted the branch on Aug 7, 2015

MarcoFalke locked this on Sep 8, 2021

[Qt] allow users to set -onion via GUI #4587