[Qt] allow users to set -onion via GUI #4587

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:proxy-gui changing 5 files +297 −7
  1. Diapolo commented at 4:22 PM on July 25, 2014: none
    • also allow users to see, if the default proxy (-proxy) is used for IPv6 and Onion
    • based on #4871 (formerly #2575)

    proxy

  2. laanwj commented at 6:44 AM on July 26, 2014: member

    Looks good.

    As discussed in #2575 I'd like to simplify this to:

    • A clearnet proxy for IPv4 and IPv6 and name-based lookups (except *.onion, and possibly other 'darknet's in the future)
    • A proxy for .onion. This defaults to the clearnet proxy *if the onion network is enabled at all.
  3. laanwj added the label GUI on Jul 31, 2014
  4. Diapolo renamed this:
    [Qt] allow users to set -proxy6 and -tor via GUI
    [Qt] allow users to set -tor via GUI
    on Sep 23, 2014
  5. Diapolo renamed this:
    [Qt] allow users to set -tor via GUI
    [Qt] allow users to set -onion via GUI
    on Sep 23, 2014
  6. Diapolo commented at 1:18 PM on September 23, 2014: none

    @laanwj Removed the -proxy6 stuff and rebased on the recently updated core pull.

  7. BitcoinPullTester commented at 1:46 PM on September 23, 2014: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4587_776d006492d75c94cbff1edf7fae760f0a95ebcf/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

  8. jonasschnelli commented at 3:06 PM on January 9, 2015: contributor

    Needs rebase or close due inactivity.

  9. Diapolo commented at 3:14 PM on January 9, 2015: none

    No, this needs review and help with #4871, which no one is interessted in :D.

  10. jonasschnelli commented at 3:23 PM on January 9, 2015: contributor

    Sorry. Your right. It's on top of #4871

  11. Diapolo commented at 1:48 PM on May 14, 2015: none

    Rebased to latest #4871 and fixed a small bug that was causing -onion to be missing in the options dialog, when the GUI setting was overridden.

  12. Diapolo commented at 5:52 AM on June 15, 2015: none

    Same here, this will be rebased after #6272 is merged.

  13. Diapolo commented at 8:38 PM on June 19, 2015: none

    Rebased and passing travis :).

  14. Diapolo commented at 7:26 PM on June 23, 2015: none

    @laanwj @jonasschnelli Mind taking a closer look now?

  15. Diapolo commented at 7:17 PM on July 21, 2015: none

    @jonasschnelli @laanwj This should be ready.

  16. jonasschnelli commented at 7:30 PM on July 21, 2015: contributor

    Gave it a short test.

    Why can't i unselect/select the IPv4/IPv6/Tor checkboxes (i didn't start reading why in the PRs description because IMO this must be clear within the app). If it's just as a visual prove what networks are supported by the proxy, it should not use read-only checkboxes.

    The new height of the settings window does somehow look strange on the other tabs. Auto-Resizing like this (https://vid.me/F53C) would be a better approach (check: http://stackoverflow.com/questions/11441809/resize-window-using-qpropertyanimation).

    IMO the autoresizing would be nice but should not hold this PR back.

  17. jonasschnelli commented at 7:31 PM on July 21, 2015: contributor

    <img width="714" alt="bildschirmfoto 2015-07-21 um 21 28 22" src="https://cloud.githubusercontent.com/assets/178464/8810518/c688a5aa-2fef-11e5-923d-3b2ceb3aff35.png">

  18. Diapolo commented at 8:44 PM on July 21, 2015: none

    @jonasschnelli I choose the read-only checkbox approach as that seemed easy to do. What elemet do you suggest? As you discovered the state is not changable via the boxes, they just give information.

    The resize issue is a different one and as far as I understand the link you gave me, this is just for getting a nice and smooth animation, but I don't even know how to resize a window so that the contents and size are matching and that it looks good ;). IMHO our client suffers from these issue nearly everywhere.

  19. jgarzik commented at 6:03 PM on July 23, 2015: contributor

    ut ACK

    Is this ready for merging? Blockers appear to be resolved.

  20. jonasschnelli commented at 6:06 PM on July 23, 2015: contributor

    Readonly-Checkboxes as visual indicator for a available option (but while actually supporting no interaction) should be avoided. But i can address this in another upcoming PR after merging.

    I would recommend to use the checkmark icon instead (https://github.com/bitcoin/bitcoin/blob/master/src/qt/res/icons/transaction2.png).

  21. Diapolo commented at 6:07 AM on July 24, 2015: none

    @jonasschnelli I'd love to get this in or you could just add a commit to it. But I'd love to move forward.

  22. jonasschnelli commented at 10:21 AM on July 24, 2015: contributor

    Doesn't compile at the moment because of the recent "emit" changes (https://github.com/bitcoin/bitcoin/pull/6433).

  23. [Qt] allow users to set -onion via GUI
    - also allow users to see, if the default proxy (-proxy) is used for
  reaching peers via IPv6 or Tor
    ed166dfa82
  24. Diapolo commented at 10:29 AM on July 24, 2015: none

    @jonasschnelli fixed the emit problem.

  25. jonasschnelli commented at 10:56 AM on July 24, 2015: contributor

    <img width="707" alt="bildschirmfoto 2015-07-24 um 12 43 12" src="https://cloud.githubusercontent.com/assets/178464/8872987/3fdcaee2-3202-11e5-9e75-8774bc27f957.png">

    <img width="295" alt="bildschirmfoto 2015-07-24 um 12 55 46" src="https://cloud.githubusercontent.com/assets/178464/8873081/5456c3f2-3203-11e5-9f2e-a07531cacd12.png">

    I think this looks better. Commit: https://github.com/jonasschnelli/bitcoin/commit/3ae243422abfbdaa8c5a56ebdf86d4fedeaa467c

  26. laanwj commented at 11:41 AM on August 7, 2015: member

    @jonasschhnelli I like what you're trying to do, but I'm not sure it's better:

    • The checkbox icon is always black, also in themes that themselves have a black background
    • It doesn't fit in with the rest of the UI (check styles are slightly different)
  27. laanwj commented at 11:41 AM on August 7, 2015: member

    Going to merge this as-is for now. You can improve it later.

  28. laanwj merged this on Aug 7, 2015
  29. laanwj closed this on Aug 7, 2015
  30. laanwj referenced this in commit 0c465f5e60 on Aug 7, 2015
  31. jonasschnelli commented at 12:01 PM on August 7, 2015: contributor

    ACK.

  32. Diapolo deleted the branch on Aug 7, 2015
  33. MarcoFalke locked this on Sep 8, 2021
Contributors
DiapololaanwjBitcoinPullTesterjonasschnellijgarzik
Labels
GUI
Linked (view graph)
#2575 extend core proxy options and handling#4871 extend core proxy options and handling#5911 privacy: Stream isolation for Tor
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me