Use 'unsigned char' rather than 'char' for pchMessageStart. #459

pull jgarzik wants to merge 1 commits into bitcoin:master from jgarzik:char-msgstart changing 2 files +2 −2

jgarzik commented at 2:45 AM on August 11, 2011: contributor

Regarding https://bitcointalk.org/index.php?topic=28022.0

main.cpp has: "char pchMessageStart[4] = { 0xf9, 0xbe, 0xb4, 0xd9 };" Per discussion on the thread linked, leaving the signedness of pchMessageStart is unsafe for values > 0x80. This patch specifies 'unsigned char' in main.cpp and net.h.

Use 'unsigned char' rather than 'char' for pchMessageStart.

Regarding https://bitcointalk.org/index.php?topic=28022.0

main.cpp has: "char pchMessageStart[4] = { 0xf9, 0xbe, 0xb4, 0xd9 };"
Per discussion on the thread linked, leaving the signedness of
pchMessageStart is unsafe for values > 0x80. This patch specifies
'unsigned char' in main.cpp and net.h.

Signed-off-by: Jeff Garzik <jgarzik@pobox.com>

25133bd74b

gavinandresen referenced this in commit c648b589be on Aug 11, 2011
gavinandresen merged this on Aug 11, 2011
gavinandresen closed this on Aug 11, 2011
jgarzik deleted the branch on Aug 24, 2014
MarcoFalke referenced this in commit fd86f998fc on Sep 29, 2017
HashUnlimited referenced this in commit 74db3b0e3c on Mar 12, 2018
lateminer referenced this in commit 79e7a13b07 on Jan 22, 2019
fjahr referenced this in commit f532bdc9f7 on Jul 24, 2019
rajarshimaitra referenced this in commit d2d04a726c on Aug 5, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

jgarzik