Rework block processing benchmark code #4593

1. 
   sipa commented at 10:49 pm on July 26, 2014: member

   • Replace -benchmark (and the related fBenchmark) with a regular debug option, -debug=bench.
   • Increase coverage and granularity of individual block processing steps.
   • Add cummulative times.

   Example output:

   0   - Load block from disk: 3.11ms [51.13s]
   1       - Connect 484 transactions: 4.14ms (0.009ms/tx, 0.005ms/txin) [64.37s]
   2     - Verify 860 txins: 4.25ms (0.005ms/txin) [66.98s]
   3     - Index writing: 1.22ms [33.53s]
   4     - Callbacks: 0.10ms [2.15s]
   5   - Connect total: 14.17ms [203.69s]
   6   - Flush: 1.00ms [19.88s]
   7   - Writing chainstate: 0.09ms [33.30s]
   8   - Connect postprocess: 0.23ms [5.15s]
   9 - Connect block: 11.96ms [313.16s]
   

   Note that the subdivisions work backwards: the grand total is the last item, ‘Connect transactions’ is a part of ‘Verify transactions’, and ‘Verify transactions’, ‘Index writing’, and ‘Callbacks’ are part of ‘Connect total’.

2. Rework block processing benchmark code

   * Replace -benchmark (and the related fBenchmark) with a regular debug option, -debug=bench.
   * Increase coverage and granularity of individual block processing steps.
   * Add cummulative times.

   d70bc52ee3
3. 
   BitcoinPullTester commented at 5:21 pm on July 27, 2014: none

   Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4593_d70bc52ee31b8c4c87ee011625e7031c2dc89c0c/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
4. 
   jgarzik commented at 4:51 pm on July 29, 2014: contributor

   ACK
5. 
   laanwj commented at 8:53 am on July 30, 2014: member

   ACK
6. laanwj merged this on Jul 30, 2014
7. laanwj closed this on Jul 30, 2014

   ---

8. laanwj referenced this in commit efec4ec6c5 on Jul 30, 2014
9. MarcoFalke locked this on Sep 8, 2021

Contributors
sipa BitcoinPullTester jgarzik laanwj