Rework block processing benchmark code #4593

pull sipa wants to merge 1 commits into bitcoin:master from sipa:morebench changing 3 files +41 −17

sipa commented at 10:49 PM on July 26, 2014: member
- Replace -benchmark (and the related fBenchmark) with a regular debug option, -debug=bench.
- Increase coverage and granularity of individual block processing steps.
- Add cummulative times.
Example output:
```
   - Load block from disk: 3.11ms [51.13s]
       - Connect 484 transactions: 4.14ms (0.009ms/tx, 0.005ms/txin) [64.37s]
     - Verify 860 txins: 4.25ms (0.005ms/txin) [66.98s]
     - Index writing: 1.22ms [33.53s]
     - Callbacks: 0.10ms [2.15s]
   - Connect total: 14.17ms [203.69s]
   - Flush: 1.00ms [19.88s]
   - Writing chainstate: 0.09ms [33.30s]
   - Connect postprocess: 0.23ms [5.15s]
 - Connect block: 11.96ms [313.16s]
```
Note that the subdivisions work backwards: the grand total is the last item, 'Connect transactions' is a part of 'Verify transactions', and 'Verify transactions', 'Index writing', and 'Callbacks' are part of 'Connect total'.

Rework block processing benchmark code

* Replace -benchmark (and the related fBenchmark) with a regular debug option, -debug=bench.
* Increase coverage and granularity of individual block processing steps.
* Add cummulative times.

d70bc52ee3

BitcoinPullTester commented at 5:21 PM on July 27, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4593_d70bc52ee31b8c4c87ee011625e7031c2dc89c0c/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
jgarzik commented at 4:51 PM on July 29, 2014: contributor

ACK
laanwj commented at 8:53 AM on July 30, 2014: member

ACK
laanwj merged this on Jul 30, 2014
laanwj closed this on Jul 30, 2014
laanwj referenced this in commit efec4ec6c5 on Jul 30, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors