Source: http://www.viva64.com/en/b/0268/
script.h: set_vch() should shift a >32 bit value #4602
pull jgarzik wants to merge 1 commits into bitcoin:master from jgarzik:susp-shift changing 1 files +1 −1-
jgarzik commented at 3:25 PM on July 29, 2014: contributor
-
6fd59ee897
script.h: set_vch() should shift a >32 bit value
Source: http://www.viva64.com/en/b/0268/
-
BitcoinPullTester commented at 3:50 PM on July 29, 2014: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4602_6fd59ee897e9dc9b021440cbb738186dbf3a3e98/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
laanwj commented at 4:01 PM on July 29, 2014: member
Can we think of a test case that distinguishes these? Or is it just defined versus undefined behavior, where the undefined behavior happens to do the right thing?
-
theuni commented at 4:19 PM on July 29, 2014: member
This is my code. Fwiw, it's very recent.
set_vch() is only called in 2 places. It's range-checked in both places, so there should be no way this could cause any real problems.
Completely agree with the change though, no reason to leave it exposed.
- jgarzik added the label Bug on Jul 31, 2014
-
laanwj commented at 7:50 AM on August 1, 2014: member
ACK
-
sipa commented at 11:33 AM on August 1, 2014: member
Untested ACK
- laanwj merged this on Aug 3, 2014
- laanwj closed this on Aug 3, 2014
- laanwj referenced this in commit 6278bd57c6 on Aug 3, 2014
- jgarzik deleted the branch on Aug 24, 2014
- MarcoFalke locked this on Sep 8, 2021
