Travis test fixes #4612

pull theuni wants to merge 2 commits into bitcoin:master from theuni:travis-test-fixes changing 2 files +2 −2

theuni commented at 6:11 PM on July 31, 2014: member

2 very simple changes.

The first redirects stderr to stdout for the comparison tool so that c-i can see that the test is doing something. The second keeps the port# from exceeding 65535 on a busy machine.
test: redirect comparison tool output to stdout
Otherwise travis thinks the build has stalled.
a67eef1723
test: don't let the port number exceed the legal range 6548cc9f90
BitcoinPullTester commented at 6:27 PM on July 31, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4612_6548cc9f9073bf6602e17f62017af5c0e2bc3457/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
in qa/pull-tester/run-bitcoind-for-test.sh.in:None in 6548cc9f90
```
   8 | @@ -9,7 +9,7 @@ mkdir -p "$DATADIR"/regtest
   9 |  touch "$DATADIR/regtest/debug.log"
  10 |  tail -q -n 1 -F "$DATADIR/regtest/debug.log" | grep -m 1 -q "Done loading" &
  11 |  WAITER=$!
  12 | -PORT=`expr $BASHPID + 10000`
  13 | +PORT=`expr 10000 + $BASHPID % 55536`
```
laanwj commented at 7:33 AM on August 1, 2014:

For a minute I was confused whether it is allowed to use port 65535, but apart from some remarks that 49152+ is 'ephermal port range', which is advisory, I could not find anything conclusive, and binding on port 65535 was no problem when I tried. But it may nevertheless make sense to use a safety margin here.
laanwj added the label Tests on Aug 1, 2014
laanwj merged this on Aug 4, 2014
laanwj closed this on Aug 4, 2014
laanwj referenced this in commit ab676c3ac4 on Aug 4, 2014
theuni commented at 3:58 AM on August 5, 2014: member

Sorry I missed your comment here before merge. I can slim down the range if you would prefer.
laanwj commented at 7:37 AM on August 5, 2014: member

Nah. On a busy system, port collisions can always happen no matter what range is used (this just avoids colliding with another bitcoind instance), so I don't think toning down the range would help.
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels