[Qt] re-work overviewpage UI #4627

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:overview changing 2 files +340 −360
  1. Diapolo commented at 11:53 AM on August 4, 2014: none
    • ensure normal and watch-only stuff looks consistent
    • simplify UI by removing unneeded UI layout elements

    overview

  2. laanwj commented at 3:04 PM on August 4, 2014: member

    Looks like alignment for Beobachtet: header should be to the right.

  3. Diapolo commented at 7:26 AM on August 5, 2014: none

    @laanwj Should the header text contain a :? I think no. Will make it align right also.

  4. laanwj commented at 7:28 AM on August 5, 2014: member

    especially if it is part of the translation message, let's just leave the ":" in there

  5. Diapolo commented at 7:57 AM on August 5, 2014: none

    @laanwj I'd like to always show watch-only and add a descriptive tooltip on how to add watch-only addresses via RPC console. It reads Shows watch-only balances from addresses you added to your wallet via importaddress (see Bitcoin RPC console and enter "help importaddress")., what do you think? Will make the changes and you can then take a look at the updated pull.

  6. sipa commented at 7:59 AM on August 5, 2014: member

    If we believe watch-only functionality is important enough to be a first-class thing in the GUI, adding them should be in the GUI too - not through the RPC console.

  7. Diapolo commented at 8:07 AM on August 5, 2014: none

    @sipa I agree, but current GUI looks so fucking ugly when watch-only is active, that I'd rather want to clean that up and will then look into how we can add a clean GUI. I have to say, that I like that feature.

  8. Diapolo commented at 8:13 AM on August 5, 2014: none

    @sipa @laanwj See new picture in first posting.

  9. laanwj commented at 8:26 AM on August 5, 2014: member

    I agree with @sipa. Note that watch-only is experimental for now, that's why there is no official way to add them. Please don't suggest that people use the debug console in a tooltip. The watch-only functionality should be completely hidden if it is not used.

    Comments about the screenshot:

    • The 'headers' (Own, Watch-only) don't stand out enough. Possible use a different font style.
    • Also I don't like 'Own:'. Maybe 'Spendable:'?
    • Remove 'Balances' in the top left corner of the table. If you want to have the word balances there, replace 'Wallet' with it.
  10. Diapolo commented at 8:35 AM on August 5, 2014: none

    @laanwj Okay, I will focus on fixing the layout and address your comments.

  11. Diapolo commented at 8:45 AM on August 5, 2014: none

    @laanwj Updated once more ^^.

  12. laanwj commented at 9:00 AM on August 5, 2014: member

    Looks a lot better already. Maybe try italic instead of underline?

  13. Diapolo commented at 11:08 AM on August 5, 2014: none

    Italic: overview_italic

    Chose wisely :).

  14. laanwj commented at 8:13 AM on August 6, 2014: member

    Well I'm sorry to be difficult, but neither looks very appealing to me. The underline 'interferes' with the summation line, whereas the italic just looks.. wiggly, the effect is overdone. ...in retrospect maybe it was better without font effect for the header. But if I have to choose, the underline wins.

  15. Diapolo commented at 8:34 AM on August 6, 2014: none

    No problem, one screenshot more with no font effect: normal

    I'll rebase after the final decission :).

  16. laanwj commented at 9:11 AM on August 6, 2014: member

    OK. Looks better without font effect. Sorry for the distraction. Let's just go with that.

  17. Diapolo commented at 9:18 AM on August 6, 2014: none

    Rebased and ready.

  18. laanwj commented at 1:32 PM on August 6, 2014: member

    ACK if you remove the part to always show watch-only.

  19. laanwj added the label GUI on Aug 6, 2014
  20. Diapolo commented at 2:33 PM on August 6, 2014: none

    @laanwj Watch-only is not shown anymore if there are no watch-only addresses.

  21. in src/qt/forms/overviewpage.ui:None in c47190c18b outdated 
      17 | -   <item>
  18 | +  <layout class="QFormLayout" name="formLayout_3">
  19 | +   <item row="0" column="0" colspan="2">
  20 |      <widget class="QLabel" name="labelAlerts">
  21 |       <property name="visible">
  22 | -      <bool>false</bool>
    laanwj commented at 2:48 PM on August 6, 2014:

    Does it affect anything that labelAlerts is initially visible?

    Diapolo commented at 8:12 PM on August 6, 2014:

    That is a mistake, will fix it. Thanks!

    Diapolo commented at 8:16 PM on August 6, 2014:

    Fixed!

  22. laanwj commented at 7:17 AM on August 7, 2014: member

    Without watch-only it still shows the 'Spendable:' header. This may be confusing, because there is nothing to contrast it to.

    untitled

  23. Diapolo commented at 7:30 AM on August 7, 2014: none

    @laanwj Damn, yeah will have to take care of that also.

  24. Diapolo commented at 7:52 AM on August 7, 2014: none

    @laanwj It's hidden now when no watch-only is active, sorry...

  25. [Qt] re-work overviewpage UI
    - ensure normal and watch-only stuff looks consistent
- simplify UI by removing unneeded UI layout elements
- change some comments to watch-only from watchonly
    94e1b9e05b
  26. in src/qt/overviewpage.cpp:None in 8f0c1534ef outdated 
     170 | -    ui->lineWatchBalance->setVisible(showWatchOnly);            // show watchonly balance separator line
 171 | -    ui->labelWatchAvailable->setVisible(showWatchOnly);         // show watchonly available balance
 172 | -    ui->labelWatchImmature->setVisible(showWatchOnlyImmature);  // show watchonly immature balance
 173 | -    ui->labelWatchPending->setVisible(showWatchOnly);           // show watchonly pending balance
 174 | -    ui->labelWatchTotal->setVisible(showWatchOnly);             // show watchonly total balance
 175 | +    ui->labelSpendable->setVisible(showWatchOnly);               // show spendable lable (only when watch-only is active)
    laanwj commented at 7:52 AM on August 8, 2014:

    lable :)

    Diapolo commented at 7:57 AM on August 8, 2014:

    Oh my... fixed!

  27. BitcoinPullTester commented at 8:16 AM on August 8, 2014: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4627_94e1b9e05b96e4fe639e5b07b7a53ea216170962/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

  28. laanwj merged this on Aug 8, 2014
  29. laanwj closed this on Aug 8, 2014
  30. laanwj referenced this in commit fffe947c48 on Aug 8, 2014
  31. Diapolo deleted the branch on Aug 8, 2014
  32. wtogami referenced this in commit fec88d84be on Sep 9, 2014
  33. wtogami referenced this in commit 9fd440820e on Sep 10, 2014
  34. wtogami referenced this in commit 0515a768bf on Sep 19, 2014
  35. wtogami referenced this in commit d5b4e4c23b on Oct 2, 2014
  36. wtogami referenced this in commit e09397d19f on Nov 14, 2014
  37. wtogami referenced this in commit 722f0ac337 on Dec 23, 2014
  38. DrahtBot locked this on Sep 8, 2021
Contributors
DiapololaanwjsipaBitcoinPullTester
Labels
GUI
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me