fixes #4630
build: Fix windows configure when using --with-qt-libdir #4633
pull ntrgn wants to merge 1 commits into bitcoin:master from ntrgn:bldfix changing 1 files +5 −0-
ntrgn commented at 11:08 PM on August 4, 2014: none
-
Fixes https://github.com/bitcoin/bitcoin/issues/4630 831bc57a7e
-
theuni commented at 11:14 PM on August 4, 2014: member
Thanks. ACK.
Edit: In the future, please provide a more descriptive commit message, though. Something like "fix windows configure when using --with-qt-libdir" would be very clear to anyone looking through a 'git log'
-
BitcoinPullTester commented at 11:22 PM on August 4, 2014: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4633_831bc57a7eb76f4ee267289c37c9c3cfe3a1c3d4/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
laanwj commented at 7:21 AM on August 5, 2014: member
The usual way to would be to make the commit title descriptive, like "build: Fix windows configure when using --with-qt-libdir", then specify "fixes #4630" somewhere in the body of the commit message. The latter makes sure that github will close the issue automatically when it is merged.
- ntrgn renamed this:
Fixes https://github.com/bitcoin/bitcoin/issues/4630
build: Fix windows configure when using --with-qt-libdir
on Aug 5, 2014 - laanwj referenced this in commit 9ce0774aba on Aug 5, 2014
-
laanwj commented at 1:41 PM on August 5, 2014: member
Merged via 9ce0774
-
- laanwj closed this on Aug 6, 2014
- reddink referenced this in commit 03709795a9 on May 27, 2020
- MarcoFalke locked this on Sep 8, 2021
