small net cleanup #4636

• add comment for disabling sigpipe
• add closing comment in compat.h
• remove redundant check in net.h

Untested ACK

@jgarzik Is it silly to at least make identical code look identical? Perhaps look at our project not at others :-/.

https://github.com/bitcoin/bitcoin/blob/master/src/net.cpp#L1642

Voila #4641

@laanwj What do you suggest so this can be megerd? Understand my intention do make identical code look identical? Just want to get this in...

@diapolo if you want to make easily mergable pulls, my suggestion would be to try to touch as few lines as possible to accomplish what you want. Also try to fix an open issue, or at least an problem. Not just your gut feeling on how the source code should look at a superficial level.

I'm not sure about some of the logging changes

- LogPrint("net", "disconnecting peer=%d\n", id);
  CloseSocket(hSocket);
+ LogPrint("net", "disconnecting peer=%d\n", id);

Why? And it now says 'disconnecting' after the peer has been disconnected.

Why? Because of consistency reasons... indeed the message is now wrong, but I'm going to update it. If such things are that controversial, you are always free to close my pulls, perhaps I'm learning that these don't matter enough ;).

IMO the worthwhile changes here are:

src/compat.h

-// Copyright (c) 2009-2013 The Bitcoin developers
+// Copyright (c) 2009-2014 The Bitcoin developers
-#endif
+#endif // _BITCOIN_COMPAT_H

• File was updated this year
• Closing comment on #endif is remotely useful

src/net.h

- if (hSocket != INVALID_SOCKET)
- {
- CloseSocket(hSocket);
- }
+ CloseSocket(hSocket);

• Check is redundant as it is already done in CloseSocket

src/netbase.cpp

+ // Different way of disabling SIGPIPE on BSD

• This comment adds non-obvious information

Could do without: the logging changes, the whitespace changes, and the variable rename

+1 @laanwj

Done!

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4636_efd6b87811351cde592ac48247190e682ad02aea/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.