The size limit makes a lot of sense for the server, as it never has to accept very large data and has to protect against malicious clients.
The client, however, can request arbitrary amounts of data (for example with listtransactions on a large wallet). Having a strict size limit makes little sense.
Fixes #4604.
The second commit contains a slight optimization that prevents a redundent copy and removes a needless c_str which would mess with binary data.
Split up HTTPReply into HTTPReply and HTTPReplyHeader, so that
the message data can be streamed directly.
Also removes a c_str(), which would have prevented binary
output with NUL characters in it.
The size limit makes a lot of sense for the server, as it never has to
accept very large data.
The client, however, can request arbitrary amounts of data with
`listtransactions` on a large wallet.
Fixes #4604.
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4640_733177ebd3ecf3a03c2acb6b244c8b3d1b4a3981/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
This pr indeed solves the issue I had at #4604 Thanks!
Untested ACK, looks good.