[Qt] multiple small changes related to bitcoingui #4649

pull Diapolo wants to merge 3 commits into bitcoin:master from Diapolo:bitcoingui changing 3 files +40 −9

Diapolo commented at 7:54 AM on August 7, 2014: none

No description provided.
laanwj added the label GUI on Aug 8, 2014
[Qt] ensure all class attributes are init to 0
- in BitcoinGUI and UnitDisplayStatusBarControl
8ca6a16176
[Qt] use BitcoinGUI::DEFAULT_WALLET constant in bitcoin.cpp 314fbd9ac7

[Qt] disable tray interactions when client model set to 0

- this prevents the ability to fiddle around with the system tray when
  already shutting down (e.g. on slow shutdowns because of a proxy delay)
- extends solution for #4360

b197bf3270

BitcoinPullTester commented at 10:28 AM on August 8, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4649_b197bf3270490068319d87e4b977b08f754a1307/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
Diapolo commented at 1:25 PM on August 14, 2014: none

@laanwj Can you take a look?

in src/qt/bitcoingui.cpp:None in b197bf3270

 455 | +        unitDisplayControl->setOptionsModel(clientModel->getOptionsModel());
 456 | +    } else {
 457 | +        // Disable possibility to show main window via action
 458 | +        toggleHideAction->setEnabled(false);
 459 | +        // Disable context menu on tray icon
 460 | +        trayIconMenu->clear();

laanwj commented at 10:52 AM on August 18, 2014:

Please check trayIconMenu for 0 here. It may still be 0 if a setClientModel(0) is done but never a setClientModel(somethingelse).

laanwj commented at 10:15 AM on August 19, 2014: member

ACK apart from that
laanwj merged this on Aug 26, 2014
laanwj closed this on Aug 26, 2014
laanwj referenced this in commit b9bd6282c5 on Aug 26, 2014
laanwj referenced this in commit f30801afbd on Aug 26, 2014
Diapolo deleted the branch on Aug 27, 2014
wtogami referenced this in commit df2241f375 on Nov 14, 2014
wtogami referenced this in commit f833435669 on Dec 23, 2014
reddink referenced this in commit 415f25807c on May 27, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels