build: fixes ignored qt 4.8 codecs path on windows when configuring with --with-qt-libdir #4654

pull ntrgn wants to merge 1 commits into bitcoin:master from ntrgn:bldfix changing 1 files +5 −5

ntrgn commented at 6:12 PM on August 7, 2014: none

No description provided.
Fixes ignored qt 4.8 codecs path on windows when configuring with --with-qt-libdir c4a77090c4
BitcoinPullTester commented at 6:27 PM on August 7, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4654_c4a77090c4b5a8346f3d312be41c1ee50830a21a/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
theuni commented at 6:45 PM on August 7, 2014: member

This looks correct, thanks for fixing these. Seems I never tested the last reshuffle with win+qt4 since we don't build releases that way anymore.

Untested ACK, until I can run a quick build to verify.
laanwj added the label Build system on Aug 8, 2014
laanwj commented at 7:25 AM on August 18, 2014: member

@theuni still planning on verifying this, or is it ok to merge as-is?
theuni commented at 4:18 AM on August 19, 2014: member

@laanwj I think it'd take me longer than it's worth to get back to a setup where I could verify this. It looks fine and I'll trust that it fixes the issue for @ntrgn .
laanwj merged this on Aug 25, 2014
laanwj closed this on Aug 25, 2014
laanwj referenced this in commit 26f3a05cf1 on Aug 25, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels