[Qt] Add TRY_LOCK back to peertablemodel #4668

pull cozz wants to merge 1 commits into bitcoin:master from cozz:cozz14 changing 1 files +8 −2

cozz commented at 12:34 AM on August 10, 2014: contributor

TRY_LOCK has been removed recently, but this causes the progressbars to freeze, because the GUI-thread is waiting for cs_main.
[Qt] Add TRY_LOCK back to peertablemodel 9297763dad
BitcoinPullTester commented at 12:48 AM on August 10, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4668_9297763dadeee2fc74fcbbbf8eb227e4930877f1/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
Diapolo commented at 12:03 PM on August 10, 2014: none

ACK, I removed it because I thought it was over careful to have it there. I didn't observe the freezing progressbar, sorry.
laanwj commented at 7:22 AM on August 11, 2014: member

Ouch, good catch.
laanwj merged this on Aug 11, 2014
laanwj closed this on Aug 11, 2014
laanwj referenced this in commit 3e089a00e7 on Aug 11, 2014
DrahtBot locked this on Sep 8, 2021

Contributors