[Qt] Add column Watch-only to transactions list #4673

pull cozz wants to merge 2 commits into bitcoin:master from cozz:cozz12 changing 19 files +172 −23
  1. cozz commented at 3:39 PM on August 10, 2014: contributor
    • Changes the condition for showing watch-only to if there has been watch-only imported or not, instead of looking at the balance. The labels should be shown, even with a balance of zero, if you run importaddress.
    • Adds new filterable dynamic column Watch-only

    watchonly_column4

    watchonly_column1

    watchonly_column2

  2. laanwj commented at 7:24 AM on August 11, 2014: member

    I don't really like adding a separate column for this with just yes/no. I'd prefer a more compact way to signal these, like changing the color, adding an icon, .... (many other things possible)

  3. laanwj commented at 7:25 AM on August 11, 2014: member

    Or, a very narrow column with just a checkbox or such would be acceptable to me too. But this one is much too wide.

  4. Add boolean HaveWatchonly and signal NotifyWatchonlyChanged 939ed97373
  5. cozz commented at 7:05 PM on August 11, 2014: contributor

    I think it would be nice, to be able to sort and filter by watchonly. Updated now with an eye-icon and narrow column.

    watchonly_column5

    watchonly_column6

  6. [Qt] Add column Watch-only to transactions list 1c5f0af0fd
  7. BitcoinPullTester commented at 7:56 PM on August 11, 2014: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4673_1c5f0af0fd8b5630470d471d8319a7c979aa2587/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

  8. laanwj commented at 7:58 PM on August 11, 2014: member

    OK this is pretty cool :)

  9. cozz commented at 8:06 PM on August 11, 2014: contributor

    Overview-page now also with eye-icon.

    watchonly_column7

  10. laanwj added the label GUI on Aug 13, 2014
  11. Diapolo commented at 1:22 PM on August 14, 2014: none

    @cozz Looks very very nice :), great work here! Are there changes to the tooltip also? Does it read watch-only in it or ist there also that eye?

  12. cozz commented at 6:47 PM on August 14, 2014: contributor

    Tooltip says nothing new currently, as I removed the (w) completely. I may add this back in, and say watch-only in the tooltip.

  13. laanwj merged this on Aug 26, 2014
  14. laanwj closed this on Aug 26, 2014

  15. laanwj referenced this in commit d49b0876a4 on Aug 26, 2014
  16. Diapolo commented at 9:22 PM on August 28, 2014: none

    @cozz See #4783

  17. wtogami referenced this in commit 9e6c5d80f1 on Sep 9, 2014
  18. wtogami referenced this in commit f891ce93bf on Sep 9, 2014
  19. wtogami referenced this in commit 04449a91ae on Sep 19, 2014
  20. wtogami referenced this in commit e692e7e0e4 on Sep 19, 2014
  21. wtogami referenced this in commit 9e01bfade8 on Oct 2, 2014
  22. wtogami referenced this in commit 47c63d5b76 on Oct 2, 2014
  23. wtogami referenced this in commit f936d43af5 on Nov 14, 2014
  24. wtogami referenced this in commit 53dcb1084b on Nov 14, 2014
  25. wtogami referenced this in commit 4be0a4d39a on Dec 23, 2014
  26. wtogami referenced this in commit 55a1e69851 on Dec 23, 2014
  27. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me