Fixes #3886 by letting qt do the downscaling from the original 256x256 bitmap.
Before/after on Ubuntu and Windows:
qt: better looking trayicon #4678
pull ntrgn wants to merge 3 commits into bitcoin:master from ntrgn:qt_trayicon changing 6 files +2 −7-
ntrgn commented at 4:53 PM on August 11, 2014: none
-
qt: better looking trayicon b0aa524774
-
laanwj commented at 5:17 PM on August 11, 2014: member
Looks good to me.
However, if you do it this way the icon will get encoded into the resource file twice resulting in wasted space.
Please make this change in the source code (https://github.com/bitcoin/bitcoin/blob/master/src/qt/bitcoingui.cpp#L482).
You can then remove the toolbar_*.png from the qrc and from the git repo as it is no longer used.
-
Avoid including resources twice c84cbaacd2
-
theuni commented at 8:39 PM on August 11, 2014: member
If deleting from git, they need to be removed from the Makefiles as well. Nuke the entries from src/Makefile.qt.include, that should fix 'make dist', which is causing the build error above.
-
ntrgn commented at 8:41 PM on August 11, 2014: none
Yep, I think they should be removed from doc/assets-attribution.md also
-
Remove assets from Makefile and documentation 3062f46785
-
BitcoinPullTester commented at 8:59 PM on August 11, 2014: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4678_3062f4678587cf038ff605c5a48ab07f2cbb543f/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
- laanwj referenced this in commit 8bfdc9acaa on Aug 12, 2014
-
laanwj commented at 11:21 AM on August 12, 2014: member
Merged via 8bfdc9a
- laanwj closed this on Aug 12, 2014
- reddink referenced this in commit e73842af06 on May 27, 2020
- MarcoFalke locked this on Sep 8, 2021
