Don't poll showmyip.com, it doesn't exist anymore #4682

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2014_08_remove_showmyip changing 1 files +1 −20

laanwj commented at 6:11 AM on August 12, 2014: member

This was bound to happen someday. That leaves us with only one candidate, checkip.dyndns.org. GetMyExternalIP should be phased out as soon as possible (resurrect #3461 / #3088).

This should also go into 0.9.3.
laanwj added the label Bug on Aug 12, 2014
BitcoinPullTester commented at 6:25 AM on August 12, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4682_c5725f14a379ad497c312d5fcb5b39ed95c6817e/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

Don't poll showmyip.com, it doesn't exist anymore

Fixes #4679.

This leaves us with only one candidate, checkip.dyndns.org.
GetMyExternalIP should be phased out as soon as possible.

c33b983903

Contributors

Labels