updated ip finding service #4686

pull rmckay wants to merge 1 commits into bitcoin:master from rmckay:master changing 1 files +4 −4
  1. rmckay commented at 4:17 PM on August 12, 2014: none

    No description provided.

  2. updated ip finding service f175a0da56
  3. laanwj commented at 4:23 PM on August 12, 2014: member

    I don't think we should be adding any new IP finding services.

    I'd rather remove the malfunctioning service (#4682), and use this as an oppertunity to resurrect #3461 / #3088.

  4. BitcoinPullTester commented at 4:31 PM on August 12, 2014: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4686_f175a0da56b78d86255520fb0862627f7a50cb4a/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

  5. rmckay commented at 4:33 PM on August 12, 2014: none

    Fair enough.. I'll just say that I run the whatismyasn.org site and am committed to keeping it running on that IP.. might be an ok temporary solution until peer based IP detection is working.. but no worries if you don't want it.

  6. laanwj added the label Improvement on Aug 13, 2014
  7. cdecker commented at 9:39 AM on August 13, 2014: contributor

    Removing the lookup altogether seems a far better alternative. The external IP lookup is even more intrusive than the DNS seeds for which we started mandating certain logging policies.

  8. laanwj commented at 9:45 AM on August 13, 2014: member
  9. cdecker commented at 9:50 AM on August 13, 2014: contributor

    @laanwj saw the branch on IRC and I'd like to test it. Currently I can only provide code review since I don't have access to a machine where I can run bitcoind from.

  10. laanwj referenced this in commit 6ae45a5978 on Aug 13, 2014
  11. laanwj commented at 12:18 PM on August 13, 2014: member

    Closing this as we want to phase out usage of these kinds of services.

  12. laanwj closed this on Aug 13, 2014

  13. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 06:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me