build: fix automake warnings about the use of INCLUDES #4689

pull theuni wants to merge 2 commits into bitcoin:master from theuni:fix-automake-warnings changing 6 files +22 −16

theuni commented at 12:35 AM on August 13, 2014: member

While we're at it, reduce the use of LIBS as well. This makes dependencies explicit.

Fixes building with (the not-yet-merged) libsecp256k1 as well.

PR as requested in #4650.
jgarzik commented at 12:38 AM on August 13, 2014: contributor

ut ACK, assuming pulltester ACK ;p
BitcoinPullTester commented at 12:49 AM on August 13, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4689_af026ec2542d79840f2f39047c46c3204044442e/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 6:24 AM on August 13, 2014: member
@theuni thanks BTW: I suppose that this ilne at the top of Makefile.am can go too:
```
AM_CPPFLAGS =  $(INCLUDES)
```
laanwj added the label Build system on Aug 13, 2014

build: fix automake warnings about the use of INCLUDES

While we're at it, reduce the use of LIBS as well. This makes dependencies
explicit.

Fixes building with (the not-yet-merged) libsecp256k1 as well.

909b3471f6

build: remove some more unused includes vars c0e5dda592
theuni commented at 4:15 PM on August 14, 2014: member

Rebased and removed a few more things as suggested by @laanwj
laanwj commented at 8:37 AM on August 15, 2014: member

How did toolbar.png end up in here :)
laanwj referenced this in commit 6b099402b4 on Aug 15, 2014
laanwj commented at 8:44 AM on August 15, 2014: member

Merged via 6b09940 (without toolbar :ghost:)
laanwj closed this on Aug 15, 2014
theuni commented at 4:10 PM on August 15, 2014: member

Heh, no clue how that happened. Busted rebase somewhere I guess. Thanks for catching and fixing.
reddink referenced this in commit fb53a93cf1 on May 27, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Labels