Strictly hash what is going to be signed #4695

pull jtimon wants to merge 4 commits into bitcoin:master from jtimon:nohash2 changing 1 files +42 −46
  1. jtimon commented at 2:13 pm on August 13, 2014: contributor
    Continues #4694. Again, more important than the optimization, I think the end result is more readable. It could be a little bit nicer by joining SignHash and Sign, but then multisig’s performance would be hurt.
  2. laanwj added the label Improvement on Aug 14, 2014
  3. jtimon commented at 1:15 pm on August 14, 2014: contributor
    Dependent on #4692
  4. jtimon force-pushed on Aug 20, 2014
  5. jtimon force-pushed on Aug 27, 2014
  6. jtimon commented at 11:52 pm on August 27, 2014: contributor
    Rebased on top of #4754
  7. jtimon commented at 2:26 pm on August 31, 2014: contributor
    Rebased on top of #4755
  8. jtimon force-pushed on Aug 31, 2014
  9. jtimon force-pushed on Aug 31, 2014
  10. jtimon force-pushed on Sep 2, 2014
  11. jtimon commented at 10:16 am on September 2, 2014: contributor
    Closing until #4754 is merged.
  12. jtimon closed this on Sep 2, 2014
  13. jtimon reopened this on Sep 8, 2014
  14. jtimon force-pushed on Sep 8, 2014
  15. Don't hash what you're not going to sign 898753401f
  16. Refactor SignSignature and higher level Solver 1b5938edc8
  17. Inline SignN only use 59bad4514c
  18. Strictly hash what is going to be signed (without hurting multisig) 9aaf3b6c02
  19. jtimon force-pushed on Sep 13, 2014
  20. BitcoinPullTester commented at 9:07 pm on September 13, 2014: none
    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4695_9aaf3b6c02e746d7db17ab260837f8736c99f4f0/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
  21. jtimon commented at 6:50 am on September 15, 2014: contributor
    I think I’ve changed my mind, at least on removing SignN. Closing for now.
  22. jtimon closed this on Sep 15, 2014
  23. MarcoFalke locked this on Sep 8, 2021


jtimon BitcoinPullTester

Labels
Refactoring

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-19 15:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me