Use libbase58 for base58 and base58check encoding/decoding #4726

pull luke-jr wants to merge 3 commits into bitcoin:master from luke-jr:libbase58 changing 25 files +642 −84

luke-jr commented at 8:37 PM on August 18, 2014: member

No description provided.

Squashed 'src/libbase58/' content from commit 3e3cfa8

git-subtree-dir: src/libbase58
git-subtree-split: 3e3cfa849e8e1b6a82bb2a5656fe670a0cffafeb

aa4cd5a6b6

Merge commit 'aa4cd5a6b6502d6747294b49935089692676d8c1' as 'src/libbase58' 6ef5cde5eb
Use libbase58 for base58 and base58check encoding/decoding b85330254c
luke-jr commented at 8:38 PM on August 18, 2014: member

Not sure the benefits outweigh the costs here. automake has some ugly edges for subprojects. :(
BitcoinPullTester commented at 9:24 PM on August 18, 2014: none
Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/p4726_b85330254cd4f1f463dd5297a832ed14dd3415ef/ for binaries and test log.

This could happen for one of several reasons:
1. It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts (please tweak those patches in qa/pull-tester)
2. It adds/modifies tests which test network rules (thanks for doing that), which conflicts with a patch applied at test time
3. It does not build on either Linux i386 or Win32 (via MinGW cross compile)
4. The test suite fails on either Linux i386 or Win32
5. The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)
If you believe this to be in error, please ping BlueMatt on freenode or TheBlueMatt here.

This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
in src/base58.cpp:None in b85330254c
```
  28 | -    // Skip and count leading '1's.
  29 | -    int zeroes = 0;
  30 | -    while (*psz == '1') {
  31 | -        zeroes++;
  32 | -        psz++;
  33 | +
```
laanwj commented at 9:28 AM on August 19, 2014:

If this accomplishes anything I'd expect it to reduce base58.cpp to a few lines or even make it possible to do away with it. But this saves hardly any code in base58.cpp!
luke-jr closed this on Aug 19, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors

luke-jr

BitcoinPullTester

laanwj