Convert entire source tree from json_spirit to UniValue. #4738

1. 
   jgarzik commented at 7:20 pm on August 20, 2014: contributor

   This first pass conversion uses a wrapper to keep mainline changes to a minimum, and keep the reviewable diff to a minimum.

   Once it’s in good shape, the wrapper may be removed, and repetitive changes may be applied to the codebase.

   Status: Does not pass some RPC money formatting tests.

   Dependencies: #4730 (fix UniValue + add unit tests)

2. UniValue: prefer .size() to .count(), to harmonize w/ existing tree 385625799c
3. UniValue: export NullUniValue global constant bd02690f5a
4. Convert tree to using univalue. Eliminate all json_spirit uses. 2765757ec8
5. 
   BitcoinPullTester commented at 7:23 pm on August 20, 2014: none

   Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/p4738_2765757ec864e672b4fabf43004747699c5923da/ for binaries and test log.

   This could happen for one of several reasons:

   1. It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts (please tweak those patches in qa/pull-tester)
   2. It adds/modifies tests which test network rules (thanks for doing that), which conflicts with a patch applied at test time
   3. It does not build on either Linux i386 or Win32 (via MinGW cross compile)
   4. The test suite fails on either Linux i386 or Win32
   5. The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)

   If you believe this to be in error, please ping BlueMatt on freenode or TheBlueMatt here.

   This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

6. jgarzik added the label Improvement on Aug 21, 2014
7. jgarzik added the label Priority Low on Aug 21, 2014
8. jgarzik added the label RPC on Aug 21, 2014
9. jgarzik added the label Tests on Aug 21, 2014
10. laanwj added this to the milestone 0.11.0 on Oct 8, 2014
11. in src/json_spirit_wrapper.h: in 2765757ec8

    0@@ -0,0 +1,17 @@
    1+#ifndef __JSON_SPIRIT_WRAPPER_H__
    

    ---

    ---

    

    Diapolo commented at 11:21 am on October 8, 2014:

    Missing license.
12. 
    Diapolo commented at 11:22 am on October 8, 2014: none

    You should then also remove the json folder from our src I guess?
13. 
    jgarzik commented at 11:26 am on October 8, 2014: contributor

    @Diapolo What files remain, for you? json folder should disappear when all files inside it disappear. That’s how git handles directories.
14. 
    Diapolo commented at 11:44 am on October 8, 2014: none

    @jgarzik I just looked at the diff here and see no removal of src/json in the pull?
15. laanwj added this to the milestone 0.12.0 on May 1, 2015
16. laanwj removed this from the milestone 0.11.0 on May 1, 2015
17. 
    laanwj commented at 12:26 pm on May 12, 2015: member

    Closing in favor of #6121 which includes this
18. laanwj closed this on May 12, 2015

    ---

19. laanwj referenced this in commit 1065bb1cd2 on Aug 28, 2015
20. laanwj referenced this in commit ea55964826 on Sep 2, 2015
21. laanwj referenced this in commit 49183bb7fb on Sep 2, 2015
22. laanwj referenced this in commit 40b556d374 on Sep 3, 2015
23. MarcoFalke locked this on Sep 8, 2021

Contributors
jgarzik BitcoinPullTester Diapolo laanwj

Labels
Refactoring Tests RPC/REST/ZMQ

Milestone
0.12.0