The homebrew instructions were outdated - berkeley-db4 hasn't worked for months, based on the questions I'm seeing on Google/SO. So I added a section explaining how to install berkeley-db4 using homebrew and move on with your life. Thanks for the rest of the documentation!
Update build-osx.md #4740
pull rktoomey wants to merge 1 commits into bitcoin:master from rktoomey:patch-1 changing 1 files +24 −1-
rktoomey commented at 10:26 PM on August 20, 2014: contributor
-
b1ed7c2938
Update build-osx.md
The homebrew instructions were outdated - berkeley-db4 hasn't worked for months, based on the questions I'm seeing on Google/SO. So I added a section explaining how to install berkeley-db4 using homebrew and move on with your life. Thanks for the rest of the documentation!
-
BitcoinPullTester commented at 10:39 PM on August 20, 2014: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4740_b1ed7c29381b5eebfa38fe95e9a31b74f25c8412/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
-
-
theuni commented at 4:22 PM on August 21, 2014: member
Looks ok to me.
I'm not sure if we'd ever want to move to depends-only build, but we could try making it the "preferred" way down the road (once pull-tester and gitian are using em) and see how it goes.
- laanwj merged this on Aug 21, 2014
- laanwj closed this on Aug 21, 2014
- laanwj referenced this in commit 752f2b36c8 on Aug 21, 2014
-
laanwj commented at 4:33 PM on August 21, 2014: member
Also merged into 0.9.3 branch through 49df14d
-
DomT4 commented at 5:35 PM on August 21, 2014: contributor
@laanwj To be fair, the makefile part of my PR was the smallest part of it. It would have been easy enough to cut that out and just update the dependency side of it, but I respect your viewpoint on this. Happy to see any documentation improvement merged.
-
-
DomT4 commented at 2:51 PM on August 22, 2014: contributor
It looks like this one was merged into the Master branch? If so, there's only one additional change I'd particularly like to suggest, which is that we stop encouraging people to force link Homebrew's OpenSSL into
/usr/local, but I need to take a look at Bitcoin's new make system and see if that's still possible. -
rktoomey commented at 3:25 PM on August 22, 2014: contributor
Is it even necessary? I didn't forcelink OpenSSL into
/usr/localand the configure/make/install proceeded just fine -bitcoindis working (although I haven't tried to turn on SSL for rpc yet). -
DomT4 commented at 3:38 PM on August 22, 2014: contributor
No, It shouldn't be necessary. Even if it was necessary, if you're using Bash you can even add the Homebrew OpenSSL directory to your $PATH temporarily, and then build, which would solve the problem in a less risky way. There are a few ways to go about achieving this without the need to force OpenSSL to link to
/usr/local. -
theuni commented at 3:42 PM on August 22, 2014: member
It shouldn't be necessary. So if that's in the docs, it should be removed.
The osx build checks to see if homebrew is being used. If it is, it queries homebrew for openssl's path and updates PKG_CONFIG_PATH to reflect it.
-
DomT4 commented at 3:19 AM on August 23, 2014: contributor
Have submitted a PR that yanks the language out.
- MarcoFalke locked this on Sep 8, 2021
Contributors