Build error on OSX #4771

issue gavinandresen opened this issue on August 27, 2014

gavinandresen commented at 10:01 PM on August 27, 2014: contributor

Compile error on my OSX 10.9.4 development machine:

sync.cpp:42:46: error: use of undeclared identifier 'itostr'
        return mutexName+"  "+sourceFile+":"+itostr(sourceLine);

Not sure if it matters, but I config with -DDEBUG_LOCKORDER

git bisect tells me:

f841aa2892ffd97d564deee103555149d9fbcd9a is the first bad commit
commit f841aa2892ffd97d564deee103555149d9fbcd9a
Author: Wladimir J. van der Laan <laanwj@gmail.com>
Date:   Wed Aug 20 16:33:55 2014 +0200

    Move `COIN` and `CENT` to core.h

    Eventually these should end up in `money.h` after monetary
    amounts are typedef'ed, but at least they don't belong in `util.h`.

:040000 040000 4095f8da261b0407d68f6e729e068f428f34674e 634ffb6cac1d9a33ef94fa2d55779f005b3008a4 M  src
bisect run success

laanwj commented at 10:50 PM on August 27, 2014: member

Ah yes, missed this one (this is indeed conditional on DEBUG_LOCKORDER), sync.cpp should include utilstrencodings.h (either in addition, or instead of util.h)
laanwj referenced this in commit c234486486 on Aug 27, 2014
laanwj commented at 11:24 PM on August 27, 2014: member

Should be fixed by d2d6f70
laanwj closed this on Aug 27, 2014
theuni commented at 3:53 AM on August 28, 2014: member

@gavinandresen Is there any way to exercise DEBUG_LOCKORDER automatically in any useful way? For example, would it be helpful for c-i to enable it so that tests take that path?
gavinandresen commented at 5:09 PM on August 29, 2014: contributor

@theuni : Sure, a c-i configuration that configs with -DDEBUG_LOCKORDER and runs unit and regression tests would exercise both compile-time problems and run-time bugs (-DDEBUG_LOCKORDER turns on run-time AssertLockHeld assertions).
reddink referenced this in commit 70110e7687 on May 27, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

gavinandresen

laanwj

theuni