Fix –disable-wallet build #4788

pull jtimon wants to merge 1 commits into bitcoin:master from jtimon:nowallet changing 1 files +1 −0

jtimon commented at 9:09 pm on August 29, 2014: contributor

When compiling after ./configure –disable-wallet you get an undeclared function error.
missing include boost/algorithm/string/replace.hpp e9dd83f0a9
jtimon commented at 9:15 pm on August 29, 2014: contributor

By the way, it would be interesting for the pull tester or travis to also build this mode, maybe the one without gui too. Also, are there many users that disable the wallet but don’t disable the gui? maybe –disable-wallet should imply –without-gui ? I can imagine more users disabling the gui but not the wallet though.
BitcoinPullTester commented at 9:23 pm on August 29, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4788_e9dd83f0a90c29f9f913f019356844a989505855/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
theuni commented at 9:35 pm on August 29, 2014: member

@jtimon There is a travis build that disables the wallet to try to catch problems like this, though it disables the gui as well (its purpose is to test the minimum config). I’m not sure if there is enough reason to justify adding a row to the matrix for this corner case?
jtimon commented at 11:58 pm on August 29, 2014: contributor

No, probably not. Furthermore, maybe this corner case should be removed completely. Of course we should give a chance to the walletless bitcoin-qt users to complain first.
sipa commented at 0:14 am on August 30, 2014: member

Untested ACK
jgarzik merged this on Aug 30, 2014
jgarzik closed this on Aug 30, 2014
jgarzik referenced this in commit 76bc6cbf61 on Aug 30, 2014
laanwj commented at 2:42 am on August 30, 2014: member

@jtimon No, it should not be removed completely! On some platforms (such as MacOSX, but also Windows) it is customary to have a GUI. No one will use disable-wallet mode, which is intended to be the future of Bitcoin Core, if it offers no basic GUI.
jtimon deleted the branch on Aug 30, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors
jtimon BitcoinPullTester theuni sipa laanwj