Debugtx2 #4815

pull rebroad wants to merge 3 commits into bitcoin:master from rebroad:debugtx2 changing 2 files +28 −3

rebroad commented at 7:17 AM on September 2, 2014: contributor

Add optional debugging for transactions, including processing "notfound" messages.
rebroad force-pushed on Sep 3, 2014
Improve askfor logging (show time it will be requested by) ef82b01922
Add debug "tx" option 1e4616856a
Process "notfound" messages, and safeguard against unreasonably long ones. db1a3bc2f1
rebroad force-pushed on Sep 3, 2014
BitcoinPullTester commented at 4:29 AM on September 3, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4815_db1a3bc2f10e7a81379c44042e730f94df51c0fb/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 9:06 AM on September 25, 2014: member

Please don't just add a new P2P message type. That should go through a discussion on the mailing list.
laanwj added the label P2P on Sep 25, 2014
rebroad commented at 12:32 AM on September 29, 2014: contributor

@laanwj I've not added a new P2P message type.
laanwj commented at 7:18 AM on September 29, 2014: member

Ok - I see it was added in 903d146. You just add a handler...
in src/main.cpp:None in db1a3bc2f1
```
4075 | @@ -4075,6 +4076,29 @@ bool static ProcessMessage(CNode* pfrom, string strCommand, CDataStream& vRecv,
4076 |          }
4077 |      }
4078 |  
4079 | +
4080 | +    else if (strCommand == "notfound")
```
laanwj commented at 10:35 AM on December 16, 2014:

Like "reject", the handling for this message this should be surrounded by if (fDebug), makes it extremely easy to flood the log of unsuspecting users otherwise - Or at least consume CPU by generating lots of messages and not logging them. It is just not necessary to parse this message at all if not debugging.
jgarzik commented at 12:33 PM on December 31, 2014: contributor

ACK once @laanwj 's feedback addressed. NAK as-is.
laanwj commented at 3:35 PM on January 7, 2015: member

Closing due to inactivity.
laanwj closed this on Jan 7, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels