0.9.3rc1 version incorrect, gitian OSX #4819

1. 
   gavinandresen commented at 3:17 pm on September 2, 2014: contributor

   The gitian-built 0.9.3rc1 OSX binary reports the wrong version in the splashscreen and about box. @theuni : I know you already know about this, filing an issue so it doesn’t get forgotten…
2. gavinandresen added the label Priority High on Sep 2, 2014
3. gavinandresen added the label Mac on Sep 2, 2014
4. gavinandresen added the label Build system on Sep 2, 2014
5. gavinandresen added this to the milestone 0.9.3 on Sep 2, 2014
6. 
   laanwj commented at 3:23 pm on September 2, 2014: member

   What version does it report?
7. 
   gavinandresen commented at 3:27 pm on September 2, 2014: contributor

   Version:

   v0.9.3.0-ga12d6ac-beta (64-bit)

8. 
   laanwj commented at 11:27 am on September 4, 2014: member

   @theuni did we ever show -rc versions in the version string? Not that I remember, at least… So although it would be nice to, this is not a reversion.
9. 
   theuni commented at 3:44 pm on September 4, 2014: member

   I don’t think anything’s changed here… I’ll go back and compare some old versions
10. 
    theuni commented at 6:29 pm on September 4, 2014: member

    Just took a look at 0.9.2rc1 for osx and linux, both show git revision and no rc.

    It wouldn’t make much sense to say v0.9.3.0-rc1-beta though. What would you prefer?

11. 
    laanwj commented at 11:53 am on September 5, 2014: member

    I don’t think this should be a blocking issue for 0.9.3 (especially as that won’t be an rc :-).

    Would be nice to have this by the time of 0.10.0rc1. Remember there is no -beta anymore in master.

12. 
    theuni commented at 5:39 pm on September 5, 2014: member

    @laanwj Ah, thanks, that’s the part I was missing. I remember seeing that debate, but for some reason I was thinking that the -beta remained.
13. 
    theuni commented at 6:03 pm on September 5, 2014: member

    Looking at this closer, I think the way to work this out is to focus the version stuff in one place or another. The logic is currently triplicated between the configure.ac, the generated build.h, and version.cpp. I believe there’s no reason for that other than legacy cruft, so it makes sense to unify them so that it’s sanely handled in one place.

    The only real distinction that needs to be made is “building from git” or “building from tarball”. In the latter case, the version should already been hard-coded.

    Will give it a go.

14. 
    laanwj commented at 6:21 pm on September 5, 2014: member

    @theuni The version information in indeed duplicated in clientversion.h. It’s still there for non-HAVE_CONFIG_H builds, though I’m not sure how much sense that makes to keep them (maybe the MSVC people like it…)
15. laanwj closed this on Sep 25, 2014

    ---

16. DrahtBot locked this on Sep 8, 2021

Contributors
gavinandresen laanwj theuni

Labels
macOS Build system