net: Remove MilliSleep from StopNode #4833

I don't understand why it would be there in the first place. This looks like voodoo, not programming.

Well.... what are the 3 LOC right before the sleep? What do they do, and why would a sleep after it be a good idea?

I assume they are there to make sure no other thread is blocking on that semaphore. The sleep is probably there to give it some time to do something...

if the sleep is important it is an awfully fragile way of doing things, there is no guarantee anything will change in those 50 milliseconds.

Seems the sleep has pretty much been there forever (much longer than the semaphore posts before it). I think we can assume that whatever reason it was there in the first place is not relevant anymore. utACK.

Well.... what are the 3 LOC right before the sleep? What do they do, and why would a sleep after it be a good idea?

Yess, why, that's the million bitcoin question. Too bad we can't ask Satoshi anymore.

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4833_bbda40226b87ab152bc24b67a1f296857e6e465f/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.