Seems all undo data was being copied twice in memory before writing to disk.
Avoid copying undo data #4835
pull sipa wants to merge 1 commits into bitcoin:master from sipa:nocopy changing 1 files +11 −8-
sipa commented at 2:12 PM on September 3, 2014: member
- laanwj added the label Improvement on Sep 4, 2014
- laanwj added the label UTXO Db and Indexes on Sep 4, 2014
-
jgarzik commented at 1:48 AM on September 15, 2014: contributor
ut ACK
-
laanwj commented at 8:59 AM on September 16, 2014: member
I like the old code slightly better - just add as we go instead of indexing tricks - but if this gives a clear performance gain it's fine with me. (if only we could use emplace...)
- sipa force-pushed on Sep 17, 2014
-
sipa commented at 6:22 PM on September 17, 2014: member
I've rewritten it to use reserve + push_back + back, rather than resize + []. A bit longer, but should be operationally identical.
-
Avoid copying undo data ab15b2ec71
- sipa force-pushed on Sep 17, 2014
-
BitcoinPullTester commented at 7:11 PM on September 17, 2014: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4835_ab15b2ec71da7a82b1b08d09c0252582668a2a60/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
laanwj commented at 7:05 AM on September 18, 2014: member
utACK
- sipa merged this on Sep 20, 2014
- sipa closed this on Sep 20, 2014
- sipa referenced this in commit 25308337d6 on Sep 20, 2014
- DrahtBot locked this on Sep 8, 2021
Contributors