Uncrustify automatic unified coding style #4847

I'd like to make a group of patches that change the coding style of C++ files in an automatics way using uncrustify tool. And, even more important, make future coding style changes automatic.

As tested in my local environment, this makes the code way more clear and easier to read and understand. Also I hope that the clean and highly readable code may bring more people to the work on the bitcoin core!

Generally, there are two ways to achieve this - (1) one huge patch or (2) many incremental patches (10 to 20 patches).

What would you suggest? Please comment!

@sipa has been working on this for a while already with clang's formatting tool See for example #4498

I did see. But the pull request of mine is there to discuss some changes in the coding style.

To reiterate:

The purpose of this patch is to propose and discuss the coding style for the Bitcoin Core source code.

The main idea of this approach is:
 - Love spaces
 - Love newlines '\n'
 - Love empty lines to delimit the code parts
 - Put curly braces **everywhere** and always on the new line

I believe that this approach produce the code that is especially
easy to read and understand for the non-pro person diving into
the world of Bitcoin.

Did you possibly mean to close this issue and continue the discussion on the pull request "blog"?

Well my point is that it would be useful if you at least start your discussion from what is already done by him (and read prior discussions which led to the current .clang-format to be merged), to avoid repeated discussions. If you start with yet another tool, it's hard to compare.

Closing this, discussion is in #4498