gettransaction RPC always includes watchonly in credit calculation? #4870

issue sipa opened this issue on September 8, 2014

sipa commented at 1:34 PM on September 8, 2014: member

in rpcwallet.cpp:gettransaction, filter is passed to wtx.GetCredit, which takes a boolean parameter fUseCache, but always includes both spendable and watchonly credit.

(I haven't tested; just judging by the code)
sipa added the label Bug on Sep 8, 2014
sipa added the label Wallet on Sep 8, 2014
cozz commented at 5:10 PM on September 8, 2014: contributor
The bug is that the filter parameter has been forgotten to add in wtx.GetCredit. Like this
```
-    int64_t GetCredit(bool fUseCache=true) const
+    int64_t GetCredit(const isminefilter& filter) const
```
The variable nWatchCreditCached is even defined in constructor, but never used. I have this and some other minor watch-only fixes laying around on my harddrive for a while now. I will look into submitting the pull request this week.
laanwj closed this on Oct 13, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels