Alert key rotation test (WIP) #4883

1. 
   laanwj commented at 11:18 AM on September 9, 2014: member

   Some scaffolding to make it easier to rotate alert keys, and to test the new keys. Adds an utility that generates the alert keys (public/private) along with test data.

   I don't think that bitcoin-genalertkey should be built by default, due to the rarity that this is used. On the other hand maintaining it as part of the repository means that it won't be out of date every time we actually need it (same goes for the utility used to generate and sign alerts).

   • Tests: test both mainnet and testnet alert keys

   Note: this pull request changes the alert keys. Do not merge yet!

2. Add bitcoin-genalertkey utility 391f0c0660
3. test: Test alerts for both testnet and mainnet 9f9ef10ec3
4. laanwj force-pushed on Sep 9, 2014
5. laanwj added the label Tests on Sep 9, 2014
6. squashme ea58720ff9
7. squashme 7ebfa0bd25
8. 
   BitcoinPullTester commented at 12:20 PM on September 9, 2014: none

   Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4883_7ebfa0bd25422b1632e472af77d19f4a89ecce10/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

9. in src/Makefile.am:None in 7ebfa0bd25

    297 | @@ -298,6 +298,30 @@ if USE_LIBSECP256K1
    298 |  endif
    299 |  bitcoin_cli_CPPFLAGS = $(BITCOIN_INCLUDES)
    300 |  #
    301 | +#
    302 | +## bitcoin-genalertkey binary #
    303 | +bitcoin_genalertkey_LDADD = \
    304 | +  $(LIBBITCOIN_SERVER) \
   

   ---

   ---

   

   sipa commented at 12:28 PM on September 9, 2014:

   That seems like a huge dependency list for such a small tool? Not that it matters much for this PR, but if it does require that much, it's something we may want to look into.

   ---

   

   laanwj commented at 12:36 PM on September 9, 2014:

   It's because alert.cpp depends on various things in LIBBITCOIN_SERVER (such as the UI interface). It's of course possible to split it up, but I didn't want to go through the trouble for a one-time thing. If the intention is to maintain this as part of the repository, there's some reason to...

   OTOH I realized it may be better to port these tools (submit alert, generate alert key etc) as python scripts w/ python-bitcoinlib instead of building them at all (so we'll just keep the test changes). This was just the quickest way...

10. 
    sipa commented at 12:31 PM on September 9, 2014: member

    Idea ACK

11. 
    wtogami commented at 12:37 AM on October 2, 2014: contributor

    Why not generate a new random key and test data each time you build the tests?

12. coblee referenced this in commit 17df5bece5 on Oct 2, 2014
13. 
    laanwj commented at 8:08 AM on October 2, 2014: member

    @wtogami seems like a good idea to me; make this part of the tests instead of a separate utility.

14. laanwj added this to the milestone 0.11.0 on Nov 17, 2014
15. coblee referenced this in commit 1762205e1a on Dec 23, 2014
16. coblee referenced this in commit 2a600cb4f4 on Jan 23, 2015
17. 
    laanwj commented at 12:34 PM on March 30, 2015: member

    Closing this for now... consensus seems to be that people would rather get rid of the alert system completely.

18. laanwj closed this on Mar 30, 2015

    ---

19. MarcoFalke locked this on Sep 8, 2021

Contributors

laanwjBitcoinPullTestersipawtogami

Milestone
0.11.0