Correct logging AcceptBlock()->AcceptBlockHeader() #4887

pull rebroad wants to merge 1 commits into bitcoin:master from rebroad:CorrectLoggingAcceptBlockHeader changing 1 files +9 −9

rebroad commented at 4:09 AM on September 10, 2014: contributor

Fix logging messages to show correct function.
BitcoinPullTester commented at 4:24 AM on September 10, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4887_48c514fc939c1769b9458e8248ad6340383063e4/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
sipa commented at 8:41 AM on September 10, 2014: member

ACK.
laanwj commented at 8:53 AM on September 10, 2014: member
If you're changing these anyway: please use __func__ and remove the (). Ie just
```
return state.Invalid(error("%s : block is marked invalid", __func__), 0, "duplicate");
```
This is more consistent with new code, and otherwise we'll have the same issue again when the function renamed or moves...
Diapolo commented at 9:04 AM on September 10, 2014: none

Ideally you also remove the space in front of :, I remember @sipa or @laanwj had told me that this is also better :).
jgarzik commented at 1:29 AM on September 15, 2014: contributor

Agree w/ @laanwj: use __func__ Make the code less fragile, easier to maintain.

If you are changing the code, change it to be more durable against cut-n-paste, function renames and code movement across functions. __func__ does this.
sipa commented at 2:05 AM on September 16, 2014: member

+1 to __func__; it means we don't constantly break things when refactoring code
rebroad force-pushed on Oct 2, 2014
Correct logging AcceptBlock()->AcceptBlockHeader() 4bb30a1eb8
rebroad force-pushed on Oct 2, 2014
rebroad commented at 12:21 AM on October 3, 2014: contributor

@jgarzik @sipa __func__s added
jgarzik commented at 1:30 AM on October 3, 2014: contributor

ut ACK
sipa merged this on Oct 3, 2014
sipa closed this on Oct 3, 2014
sipa referenced this in commit 5ccd735d30 on Oct 3, 2014
rebroad deleted the branch on Aug 8, 2016
MarcoFalke locked this on Sep 8, 2021

Contributors