Use explicit fflush() instead of setvbuf() #4892

pull ajweiss wants to merge 1 commits into bitcoin:master from ajweiss:ajw_1409_stdout changing 2 files +1 −1

ajweiss commented at 4:35 PM on September 10, 2014: contributor

Flushing after every line when printing to console is desirable when running with systemd but setvbuf() has slightly different semantics on Windows that causes warnings. Just do an explicit fflush() after each line print to console instead.

Fixes #4884
jgarzik commented at 4:38 PM on September 10, 2014: contributor

ut ACK once nit fixed

Use explicit fflush() instead of setvbuf()

Flushing after every line when printing to console is desirable when
running with systemd but setvbuf() has slightly different semantics
on Windows that causes warnings.  Just do an explicit fflush() after
each line print to console instead.

e982b574a5

ajweiss force-pushed on Sep 10, 2014
ajweiss commented at 4:53 PM on September 10, 2014: contributor

Good point. Didn't notice the other stdio stuff in there. It's back in there now.
BitcoinPullTester commented at 5:06 PM on September 10, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4892_e982b574a5e8878fb50f8f75c179474f2b1661dd/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj merged this on Sep 11, 2014
laanwj closed this on Sep 11, 2014
laanwj referenced this in commit 8040e938c5 on Sep 11, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors

ajweiss

jgarzik

BitcoinPullTester

Linked (view graph)

#4884 setvbuf() call in init causes a warning/error on Windows