Compily 0.9.3 ,Encountered an error #4904

issue cqtenq opened this issue on September 12, 2014

cqtenq commented at 3:58 PM on September 12, 2014: contributor

I am compiling bitcoin-0.9.3, have some undefined reference about UPNP. But I had made miniupnpc-1.9.

make[3]: Entering directory /D/BTC/Dev/bitcoin-0.9.3/src' CXXLD bitcoind.exe libbitcoin_server.a(net.o): In functionZ13ThreadMapPortv': d:\BTC\Dev\bitcoin-0.9.3\src/net.cpp:1066: undefined reference to _imp__upnpDiscover' d:\BTC\Dev\bitcoin-0.9.3\src/net.cpp:1073: undefined reference to_imp__UPNP_GetValidIGD'
theuni commented at 4:36 PM on September 12, 2014: member

libminiupnp changed their export define. This was fixed in master with 9f7f504efca27c7d390f121410846b45c1732761 .

If you're building a .9.3 release by hand, you'll need to define MINIUPNP_STATICLIB. Easiest way to do that would be ./configure CPPFLAGS="-DMINIUPNP_STATICLIB"
theuni commented at 4:40 PM on September 12, 2014: member

@laanwj It's probably worth backporting that change to .9.3. if it's not too late.
laanwj commented at 4:51 PM on September 12, 2014: member

The option rename is in 0.9.3, together with the miniupnp version bump.
theuni commented at 4:54 PM on September 12, 2014: member

@laanwj Ah I see, it was renamed in .9.3 but the old define was dropped. So it'll work when building against new miniupnpc, but not older. So the opposite of what I said above.

Speaking of non-gitian builds here, gitian builds are obviously not affected.
laanwj commented at 5:03 PM on September 12, 2014: member

Please use miniupnpc 1.9.20140701 or later with 0.9.3, that will get rid of the issue.
cqtenq commented at 5:57 PM on September 12, 2014: contributor

I remove define USE_UPNP in bitcoin-config.h
laanwj commented at 7:32 AM on September 13, 2014: member

Passing --without-miniupnpc on configure will do the same.
laanwj closed this on Sep 25, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors

cqtenq

theuni

laanwj