Bugfix: bitcoin-tx: scriptPubKey may be null, so accept outscript=<n>: #4909

pull luke-jr wants to merge 2 commits into bitcoin:master from luke-jr:bctx_nullout changing 4 files +7 −3

luke-jr commented at 5:29 AM on September 14, 2014: member

No description provided.
Bugfix: bitcoin-tx: scriptPubKey may be null, so accept outscript=<n>: 15ef1b905b
luke-jr commented at 5:30 AM on September 14, 2014: member

I tested this on testnet3; txid aca2f7d70e26bd2d902d50ec80a2bb6cd64d36894e8f3fa1eebcc1620b8c722b
jgarzik commented at 5:47 AM on September 14, 2014: contributor

Fix is correct. Can you please add a test that fails in master, and works with your fix?

The execution command line goes into src/test/data/bitcoin-util-test.json, and typically you either (a) prepare a canned output for comparison, or (b) indicate bitcoin-tx returns a failure error code.
luke-jr commented at 6:06 AM on September 14, 2014: member

done

jgarzik commented at 6:26 AM on September 14, 2014: contributor

Traceback (most recent call last):
  File "./test/bitcoin-util-test.py", line 11, in <module>
    "bitcoin-util-test.json")
  File "/mnt/bitcoin/linux-build/src/test/bctest.py", line 50, in bctester
    bctest(testDir, testObj)
  File "/mnt/bitcoin/linux-build/src/test/bctest.py", line 24, in bctest
    outputData = open(testDir + "/" + outputFn).read()
IOError: [Errno 2] No such file or directory: u'./test/data/txcreate2.hex'
FAIL: test/bitcoin-util-test.py

is probably caused by Makefile.test.include's EXTRA_DIST needing an update.

bitcoin-util-test: Test bitcoin-tx with null scriptPubKey a65e320747
jgarzik commented at 6:28 AM on September 14, 2014: contributor

ut ACK once pull tester happy
luke-jr force-pushed on Sep 14, 2014
BitcoinPullTester commented at 6:43 AM on September 14, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4909_a65e320747133723f02c1947a4cc257214325b0b/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
sipa commented at 3:33 PM on September 14, 2014: member

ut ACK
jgarzik merged this on Sep 14, 2014
jgarzik closed this on Sep 14, 2014
jgarzik referenced this in commit a0a8700bc8 on Sep 14, 2014
luke-jr deleted the branch on Jan 1, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors