Improve rpc info for importprivkey (to make it clearer on syntax) #4922

pull rebroad wants to merge 1 commits into bitcoin:master from rebroad:ImproveImportprivkeyHelp changing 1 files +1 −1

rebroad commented at 11:32 AM on September 15, 2014: contributor

To fix issue #1085 (well, not the actual issue, which is closed, but the comments made after it was closed - i.e. make the help text clearer).
Improve rpc info for importprivkey (to make it clearer on syntax) ce24f33857
laanwj commented at 11:44 AM on September 15, 2014: member

you probably want to do the same for importaddress
laanwj commented at 11:45 AM on September 15, 2014: member

Also, please keep using round parenthesis ( ), we use this in all commands.
rkfg commented at 11:51 AM on September 15, 2014: none
This doesn't look consistent with other options because there are also:
```
getrawmempool ( verbose )
listaccounts ( minconf )
listreceivedbyaccount ( minconf includeempty )
listreceivedbyaddress ( minconf includeempty )
sendrawtransaction "hexstring" ( allowhighfees )
```
and many other options. They are not clearly described and (if I understand the syntax correctly) all expect boolean values.
BitcoinPullTester commented at 11:57 AM on September 15, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4922_ce24f338576fadd1c1a2e31660c901f4c9947d11/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

in src/rpcdump.cpp:None in ce24f33857

  69 | @@ -70,7 +70,7 @@ Value importprivkey(const Array& params, bool fHelp)
  70 |  {
  71 |      if (fHelp || params.size() < 1 || params.size() > 3)
  72 |          throw runtime_error(
  73 | -            "importprivkey \"bitcoinprivkey\" ( \"label\" rescan )\n"
  74 | +            "importprivkey \"bitcoinprivkey\" [label] [rescan=true]\n"

laanwj commented at 12:10 PM on September 15, 2014:

Also "label" should keep string syntax

laanwj commented at 10:02 AM on September 16, 2014: member

NACK as it is now, this breaks the current style in any way imaginable.
laanwj closed this on Sep 18, 2014
rebroad deleted the branch on Sep 29, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors

Linked (view graph)

#1085 importprivkey is very slow