Script destinations break-out #4934

pull theuni wants to merge 3 commits into bitcoin:master from theuni:reducescriptdeps changing 23 files +158 −80
  1. theuni commented at 6:42 AM on September 17, 2014: member

    More work on reducing script dependencies. I'm not sure if this is wanted yet, if not I'm fine with holding off.

    This allows CScript to work without knowledge of CTxDestination. Most of the dependencies on key.h are dropped, and a boost dependency is dropped as well. Next obvious steps would be to do the same for CPubKey, move SetMultisig() out, etc. This seemed like a good stopping point before continuing with those.

  2. script: break out destination functionality 7669b6ec13
  3. script: Hook up new destination functions 70654d710b
  4. script: Use bare vectors here rather than core classes bed34efe86
  5. laanwj commented at 6:50 AM on September 17, 2014: member

    Can you rebase this on top of @sipa's #4899? I plan to merge that next, and I'm sure multiple sets of changes to script will conflict.

  6. theuni commented at 6:51 AM on September 17, 2014: member

    And now I see #4899....

  7. theuni commented at 6:53 AM on September 17, 2014: member

    I've tried to keep up with the script movement PRs, but looks like I missed some. I'll have a look at this again tomorrow, very possible that this was a completely duplicated effort.

  8. laanwj commented at 6:56 AM on September 17, 2014: member

    Yes it looks like some coordination is needed to make sure we're all on the same page. For ages hardly anyone touched the script headers at all but recently there has been a flurry of activity.

  9. BitcoinPullTester commented at 6:58 AM on September 17, 2014: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4934_bed34efe865fde80e7b0db1b4419c9d55fe66341/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

  10. theuni commented at 7:04 AM on September 17, 2014: member

    Yea, this is an exact duplicate of #4899. @sipa nice work :)

  11. theuni closed this on Sep 17, 2014

  12. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-18 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me