qt: Change splash screen to normal window #4941

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2014_09_splashscreen_normal changing 3 files +58 −19

laanwj commented at 11:18 AM on September 18, 2014: member

Makes it possible to move, minimize, unminimize the window while Bitcoin Core is initializing.

Fixes: any splash-screen related issue ever; at least #4915 #4644
laanwj added the label GUI on Sep 18, 2014

qt: Change splash screen to normal window

Makes it possible to move, minimize, unminimize the window while
Bitcoin Core is initializing.

a49f11d9ed

laanwj force-pushed on Sep 18, 2014
BitcoinPullTester commented at 11:47 AM on September 18, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4941_a49f11d9edf2f7dbce154ca370494a8f86e013d0/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
cozz commented at 6:12 PM on September 19, 2014: contributor

Works for me. (linux qt4 and qt5)
theuni commented at 6:44 PM on September 19, 2014: member

works as intended on osx.
laanwj merged this on Sep 22, 2014
laanwj closed this on Sep 22, 2014
laanwj referenced this in commit 6b09bc45b1 on Sep 22, 2014
laanwj commented at 7:36 AM on September 22, 2014: member

Just after merging I realize that this makes it possible to close (using the corner X) the splash screen. The same is possible for the window shown on shutdown. This is not harmful in itself, but does still create a way to close the window without a way to bring it back. Probably should be disallowed at some point.

in src/qt/splashscreen.cpp:None in a49f11d9ed

  21 | -    QSplashScreen(pixmap, f)
  22 | +SplashScreen::SplashScreen(Qt::WindowFlags f, bool isTestNet) :
  23 | +    QWidget(0, f), curAlignment(0)
  24 |  {
  25 | -    setAutoFillBackground(true);
  26 | +    //setAutoFillBackground(true);

Diapolo commented at 12:29 PM on September 22, 2014:

@laanwj Is this left in by intention?

laanwj commented at 1:03 PM on September 22, 2014:

We paint the entire background so it should not be necessary

pull[bot] referenced this in commit 2b12268095 on Dec 7, 2018
jasonbcox referenced this in commit 75732ddc22 on Oct 9, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#4644 Make status always available during startup, e.g. toggling splash screen, or systray tooltip #4915 Loading splash screen disappears when clicked on #14854 qt: Cleanup SplashScreen class