Running base64/32_tests revealed that empty string Test case: vstrOut[] = {"", .. }; generates an exception. <br> If vector has no elements (size == 0) calling vchRet[0] throws an out of bounds exception.
Fixing error: 'vector out of bounds' issue in base 32 and 64 #4944
pull ENikS wants to merge 1 commits into bitcoin:master from ENikS:vector_subscript_out_of_range changing 1 files +2 −2-
ENikS commented at 9:10 PM on September 18, 2014: contributor
-
Fixing 'vector out of bounds' issue in base 32 and 64 018cec7c41
- ENikS renamed this:
Fixing 'vector out of bounds' issue in base 32 and 64
Fixing error: 'vector out of bounds' issue in base 32 and 64
on Sep 18, 2014 -
BitcoinPullTester commented at 9:24 PM on September 18, 2014: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4944_018cec7c41e5fca9cfe80c618444a4d343fc44e2/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
theuni commented at 10:00 PM on September 18, 2014: member
ACK
-
laanwj commented at 6:31 AM on September 19, 2014: member
utACK
- sipa merged this on Sep 19, 2014
- sipa closed this on Sep 19, 2014
- sipa referenced this in commit 2fc6c67400 on Sep 19, 2014
- ENikS deleted the branch on Sep 19, 2014
- DrahtBot locked this on Sep 8, 2021
Contributors