Linking error: Removed erroneous _MSC_VER condition preventing correct linking #4947

Removed preprocessor condition preventing building of script tests

Seems strange that we need both of these. This construction isn't to spec, so if it works it means the compiler allows it. In that case, I should think it would work both ways. I suspect that only the const iterator ctor is necessary.

Either way, I don't see the downside if it gets msvc building (and passes tests there).

utACK

utACK @theuni what is not to spec about this code? These both look perfectly fine to me:

    CScript(const_iterator pbegin, const_iterator pend) : std::vector<unsigned char>(pbegin, pend) { }
    CScript(const unsigned char* pbegin, const unsigned char* pend) : std::vector<unsigned char>(pbegin, pend) { }

You could of course shave one function off by using a templated constructor as std::vector itself has,

    template <class InputIterator>
         vector (InputIterator first, InputIterator last) {...}

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4947_feba5595963c2a18462964cdb2d4d18f7eef16aa/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

@laanwj nevermind, seems you're right. I had this in mind: https://gcc.gnu.org/onlinedocs/libstdc++/faq.html#faq.iterator_as_pod , but we're doing the opposite here.